Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Remove NotifyReceiver from new-streaming parquet source #18540

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Sep 4, 2024

It is not an efficient channel abstraction (it causes unnecessary delay/wakeups) and was not needed, we simply just put the morsel_stream_starter into the metadata task

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (04d0978) to head (74bf5de).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/parquet_source.rs 0.00% 87 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18540      +/-   ##
==========================================
- Coverage   79.87%   79.85%   -0.02%     
==========================================
  Files        1501     1500       -1     
  Lines      201823   201800      -23     
  Branches     2868     2868              
==========================================
- Hits       161200   161149      -51     
- Misses      40077    40105      +28     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review September 4, 2024 07:42
@ritchie46 ritchie46 merged commit af8738c into pola-rs:main Sep 4, 2024
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants