fix: Fix type inference error in map_elements for List types
#18542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
stinodego
commented
Sep 4, 2024
Comment on lines
+49
to
+52
| let dt = series.dtype(); | ||
|
|
||
| // Null dtype may be incorrect, fall back to AnyValues logic. | ||
| if dt.is_nested_null() { |
There was a problem hiding this comment.
This is the fix - the rest is minor refactoring.
stinodego
force-pushed
the
fix-map-skip-nulls
branch
from
f1fe8d8
to
da689fd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18542 +/- ##
==========================================
+ Coverage 79.80% 79.82% +0.02%
==========================================
Files 1501 1502 +1
Lines 201952 201950 -2
Branches 2868 2868
==========================================
+ Hits 161163 161215 +52
+ Misses 40243 40189 -54
Partials 546 546 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #18472
There are more related errors here - picking those up separately.