fix(rust): Decimal mean agg dtype was incorrect in IR #18577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
reviewed
Sep 6, 2024
| @@ -3,7 +3,8 @@ use recursive::recursive; | |||
| use super::*; | |||
|
|
|||
| fn float_type(field: &mut Field) { | |||
| if (field.dtype.is_numeric() || field.dtype == DataType::Boolean) | |||
| if (field.dtype.is_numeric() | |||
| || matches!(field.dtype, DataType::Decimal(..) | DataType::Boolean)) | |||
There was a problem hiding this comment.
Datatype variant is feature flagged.
Though I think we should remove that flag and have all dtypes, but only the implementations feature flagged.
There was a problem hiding this comment.
@ritchie46 It's a no-win situation, because then you need to feature flag calls to those implementations =/
There was a problem hiding this comment.
Alright, then feature gate the datatype. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.