Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Correctly support more types in new-streaming sum #18580

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 5, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 5, 2024
@ritchie46
Copy link
Member

You need to add some #[cfg(feature = "dtype-decimal)] and the likes.

Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #18580 will improve performances by 25.15%

Comparing orlp:new-streaming-sum (8c93e49) with main (e09cd0b)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main orlp:new-streaming-sum Change
test_groupby_h2oai_q7 2.6 ms 2.1 ms +25.15%

@orlp orlp merged commit f493f37 into pola-rs:main Sep 6, 2024
19 of 21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants