refactor(rust): Remove extra schema traits #18616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18616 +/- ##
==========================================
- Coverage 79.94% 79.92% -0.03%
==========================================
Files 1505 1506 +1
Lines 202579 203047 +468
Branches 2873 2889 +16
==========================================
+ Hits 161958 162282 +324
- Misses 40073 40215 +142
- Partials 548 550 +2 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
ritchie46
approved these changes
Sep 9, 2024
|
Can you rebase? |
nameexhaustion
force-pushed
the
schema-traits
branch
from
5878b69
to
d95c0c2
Compare
ritchie46
reviewed
Sep 9, 2024
| @@ -26,7 +26,7 @@ pub fn lower_ir( | |||
| let output_schema = IR::schema_with_cache(node, ir_arena, schema_cache); | |||
| let node_kind = match ir_node { | |||
| IR::SimpleProjection { input, columns } => { | |||
| let columns = columns.get_names_owned(); | |||
| let columns = columns.iter_names().cloned().collect::<Vec<_>>(); | |||
There was a problem hiding this comment.
Given that we call this often, a utility method might save some code bloat. 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polars_schema::Schema<D>structSchema<D>, most functions don't needD: Default + Clone