Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Don't traverse file list twice for extension validation #18620

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Sep 9, 2024

Also fixes a panic when the expanded paths were empty

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Sep 9, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review September 9, 2024 07:05
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.89%. Comparing base (aa3b2c3) to head (5df1754).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18620      +/-   ##
==========================================
- Coverage   79.94%   79.89%   -0.05%     
==========================================
  Files        1505     1506       +1     
  Lines      202579   203071     +492     
  Branches     2873     2889      +16     
==========================================
+ Hits       161958   162253     +295     
- Misses      40073    40268     +195     
- Partials      548      550       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Can you rebase?

@ritchie46 ritchie46 merged commit 1a1796a into pola-rs:main Sep 9, 2024
24 checks passed
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #18620 will degrade performances by 30.68%

Comparing nameexhaustion:empty-expansion (5df1754) with main (aa3b2c3)

Summary

❌ 1 regressions
✅ 38 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main nameexhaustion:empty-expansion Change
test_groupby_h2oai_q1 2.1 ms 3.1 ms -30.68%

@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
@nameexhaustion nameexhaustion deleted the empty-expansion branch September 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants