Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Use IO[bytes] instead of BytesIO in DataFrame.write_parquet() #18652

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented Sep 10, 2024

Closes #18651

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Sep 10, 2024
@0xbe7a 0xbe7a changed the title fix(python): Use IO[bytes] instead of BytesIO fix(python): DataFrame.write_parquet() Use IO[bytes] instead of BytesIO Sep 10, 2024
@0xbe7a 0xbe7a changed the title fix(python): DataFrame.write_parquet() Use IO[bytes] instead of BytesIO fix(python): Use IO[bytes] instead of BytesIO in DataFrame.write_parquet() Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (5ccb238) to head (44298d9).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18652      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.02%     
==========================================
  Files        1506     1506              
  Lines      203182   203204      +22     
  Branches     2891     2891              
==========================================
- Hits       162377   162365      -12     
- Misses      40255    40289      +34     
  Partials      550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite
Copy link
Collaborator

Note that passing file handles passes from python like this only really works on unix based systems. On windows, it will throw a warning because we cannot really deal with it.

I don't necessarily disagree with this PR. I just do think it should be noted.

@ritchie46 ritchie46 merged commit 149d6b9 into pola-rs:main Sep 11, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.write_parquet() expects an argument of type BinaryIO instead of IO[bytes].
3 participants