refactor(rust): Re-use already decoded metadata for first path (new-parquet-source) #18656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18656 +/- ##
==========================================
- Coverage 79.91% 79.90% -0.02%
==========================================
Files 1511 1512 +1
Lines 203201 203218 +17
Branches 2891 2891
==========================================
- Hits 162388 162376 -12
- Misses 40263 40292 +29
Partials 550 550 ☔ View full report in Codecov by Sentry. |
nameexhaustion
force-pushed
the
pqs-first-metadata
branch
from
1d8bab3
to
072f0b5
Compare
nameexhaustion
commented
Sep 10, 2024
| pub const fn empty() -> Self { | ||
| Self::from_static(&[]) | ||
| } | ||
| pub const EMPTY: Self = Self::from_static(&[]); |
There was a problem hiding this comment.
drive-by - MemSlice::EMPTY similar to PlSmallStr::EMPTY
nameexhaustion
requested review from
ritchie46,
orlp,
c-peters and
coastalwhite
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the double-fetch/decode of the first file