Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Back arrow arrays with SharedStorage which can have non-refcounted static slices #18666

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 10, 2024

We use this ability to make all small zero bitmasks share memory, without contention. We just leak 1MiB of zeroed memory once and then everything can refer to that.

We should extend this in the future also to zeroed PrimitiveArrays, referring to the same memory (the alignment of the memory has to be increased then).

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 97.10145% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.93%. Comparing base (ad9a1d8) to head (e6fa9c6).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/bitmap/immutable.rs 93.75% 3 Missing ⚠️
crates/polars-arrow/src/array/binview/mod.rs 0.00% 2 Missing ⚠️
crates/polars-arrow/src/storage.rs 99.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18666      +/-   ##
==========================================
- Coverage   79.94%   79.93%   -0.02%     
==========================================
  Files        1511     1511              
  Lines      203195   203212      +17     
  Branches     2891     2891              
==========================================
- Hits       162439   162431       -8     
- Misses      40206    40231      +25     
  Partials      550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 43cc962 into pola-rs:main Sep 11, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants