Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Qcut all nulls panics #18667

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

yarimiz
Copy link
Contributor

@yarimiz yarimiz commented Sep 10, 2024

This PR is fixing an issue where if qcut is called for a series wth only null values, and with labels as an argument, it will panic.
Fixing #10876

I've modified qcut function to call cut with None as labels after detecting all values are null in the series.
A unit test was added to check this specific scenario

@yarimiz yarimiz changed the title Qcut all nulls panics fix(rust): Qcut all nulls panics Sep 10, 2024
@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars and removed title needs formatting labels Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.94%. Comparing base (5c4e7e9) to head (409233c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18667      +/-   ##
==========================================
+ Coverage   79.90%   79.94%   +0.03%     
==========================================
  Files        1512     1513       +1     
  Lines      203203   203335     +132     
  Branches     2891     2892       +1     
==========================================
+ Hits       162379   162546     +167     
+ Misses      40274    40241      -33     
+ Partials      550      548       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit eac567f into pola-rs:main Sep 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants