Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Push down max row group height calc to file metadata #18674

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

nameexhaustion
Copy link
Collaborator

This saves a traversal

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.93%. Comparing base (5c4e7e9) to head (9710af2).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...-stream/src/nodes/parquet_source/metadata_fetch.rs 0.00% 16 Missing ⚠️
...m/src/nodes/parquet_source/row_group_data_fetch.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18674      +/-   ##
==========================================
+ Coverage   79.90%   79.93%   +0.02%     
==========================================
  Files        1512     1512              
  Lines      203203   203189      -14     
  Branches     2891     2891              
==========================================
+ Hits       162379   162424      +45     
+ Misses      40274    40215      -59     
  Partials      550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1ee85a3 into pola-rs:main Sep 11, 2024
21 checks passed
@nameexhaustion nameexhaustion deleted the pq-s-max-rg branch September 11, 2024 08:04
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants