Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Add missing PhantomDatas to BackingStorage #18699

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 11, 2024

Whenever we have *mut T to actually store an owning reference to T, that struct should also have PhantomData<T>.

https://github.com/rust-lang/rfcs/blob/master/text/0769-sound-generic-drop.md#phantom-data

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.92%. Comparing base (fcf03de) to head (e82247c).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18699   +/-   ##
=======================================
  Coverage   79.92%   79.92%           
=======================================
  Files        1513     1513           
  Lines      203329   203340   +11     
  Branches     2892     2892           
=======================================
+ Hits       162501   162520   +19     
+ Misses      40280    40272    -8     
  Partials      548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit df3c75a into pola-rs:main Sep 12, 2024
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants