Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): Fix use of undeclared crate or module error #18701

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(rust): Fix use of undeclared crate or module error #18701

merged 1 commit into from
Sep 12, 2024

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Sep 12, 2024

Fixes #18698

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Sep 12, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #18701 will improve performances by 27.67%

Comparing ankane:futures-fix (26fa7ae) with main (fcf03de)

Summary

⚡ 1 improvements
✅ 38 untouched benchmarks

Benchmarks breakdown

Benchmark main ankane:futures-fix Change
⚡ test_pdsh_q14 2.5 ms 1.9 ms +27.67%

ritchie46
ritchie46 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@ritchie46 ritchie46 merged commit 4902aba into pola-rs:main Sep 12, 2024
19 checks passed
@ankane
Copy link
Contributor Author

ankane commented Sep 12, 2024

Thanks @ritchie46!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use of undeclared crate or module futures with polars 0.43.0
2 participants
@ankane @ritchie46