Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix scalar literals #18707

Merged
merged 3 commits into from
Sep 12, 2024
Merged

fix: Fix scalar literals #18707

merged 3 commits into from
Sep 12, 2024

Conversation

ritchie46
Copy link
Member

fixes #18686

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.91%. Comparing base (79b91c3) to head (cf5b4b3).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/scalar/mod.rs 0.00% 1 Missing ⚠️
crates/polars-plan/src/plans/lit.rs 83.33% 1 Missing ⚠️
.../polars-python/src/lazyframe/visitor/expr_nodes.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18707      +/-   ##
==========================================
- Coverage   79.92%   79.91%   -0.02%     
==========================================
  Files        1513     1513              
  Lines      203334   203356      +22     
  Branches     2892     2892              
==========================================
- Hits       162510   162505       -5     
- Misses      40276    40303      +27     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a66532d into main Sep 12, 2024
25 checks passed
@ritchie46 ritchie46 deleted the scalar2 branch September 12, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.7.0 Regression] Lit with a list creates a series of one element, thus with_columns fails.
1 participant