-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Keep scalar in more places #18775
Merged
ritchie46
merged 7 commits into
pola-rs:main
from
coastalwhite:refactor/column-scalar-opts
Sep 23, 2024
Merged
refactor: Keep scalar in more places #18775
ritchie46
merged 7 commits into
pola-rs:main
from
coastalwhite:refactor/column-scalar-opts
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
changed the title
Refactor/column scalar opts
refactor: Keep scalar in more places
Sep 16, 2024
github-actions
bot
added
internal
An internal refactor or improvement
python
Related to Python Polars
rust
Related to Rust Polars
and removed
title needs formatting
labels
Sep 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18775 +/- ##
==========================================
- Coverage 79.86% 79.79% -0.07%
==========================================
Files 1517 1518 +1
Lines 205533 205758 +225
Branches 2892 2899 +7
==========================================
+ Hits 164142 164186 +44
- Misses 40843 41024 +181
Partials 548 548 ☔ View full report in Codecov by Sentry. |
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
September 17, 2024 10:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.