Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove extra hashmap construction in new-streaming parquet #18792

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Sep 17, 2024

ArrowSchema lookup is now O(1)

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (f631502) to head (c895a2e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...-stream/src/nodes/parquet_source/metadata_utils.rs 0.00% 6 Missing ⚠️
...-stream/src/nodes/parquet_source/metadata_fetch.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18792   +/-   ##
=======================================
  Coverage   79.83%   79.84%           
=======================================
  Files        1518     1518           
  Lines      205567   205563    -4     
  Branches     2892     2892           
=======================================
+ Hits       164124   164135   +11     
+ Misses      40895    40880   -15     
  Partials      548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review September 17, 2024 13:17
@ritchie46 ritchie46 merged commit 5d81d4a into pola-rs:main Sep 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants