fix: DataFrame plot was raising when some extra keywords were passed to encodings (e.g. x=alt.X(a, axis=alt.Axis(labelAngle=30)))
#18836
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
MarcoGorelli
force-pushed
the
plot-x-with-axis
branch
from
03c1c64
to
f792361
Compare
…to encodings (e.g. `x=alt.X(a, axis=alt.Axis(labelAngle=30))`)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18836 +/- ##
==========================================
- Coverage 79.86% 79.85% -0.01%
==========================================
Files 1518 1518
Lines 205610 205614 +4
Branches 2893 2894 +1
==========================================
- Hits 164202 164198 -4
- Misses 40860 40868 +8
Partials 548 548 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie and
reswqa
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18830
cc @dangotbanned in case you have time/interest to take a look
Summary: the solution used in #18625 breaks if some extra options (e.g.
sort,axis) are specified to theencodearguments. What I'm proposing is to extract'shorthand'in such cases, so that the tooltips can keep being shown by default