Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use proper thread pool in cumulative_eval #18885

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: Use proper thread pool in cumulative_eval #18885

merged 1 commit into from
Sep 24, 2024

Conversation

ritchie46
Copy link
Member

fixes #18884

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 24, 2024
@ritchie46 ritchie46 merged commit f1133a4 into main Sep 24, 2024
19 of 20 checks passed
@ritchie46 ritchie46 deleted the pool branch September 24, 2024 11:26
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (56bdc4e) to head (778ad60).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-lazy/src/dsl/eval.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18885      +/-   ##
==========================================
+ Coverage   79.85%   79.86%   +0.01%     
==========================================
  Files        1520     1520              
  Lines      206543   206545       +2     
  Branches     2906     2906              
==========================================
+ Hits       164926   164956      +30     
+ Misses      41069    41041      -28     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with parallel cumulative_eval
1 participant