Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly zip struct validities #18886

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

coastalwhite
Copy link
Collaborator

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 79.47368% with 39 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (58265f6) to head (f8b71c8).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/chunked_array/ops/zip.rs 79.25% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18886      +/-   ##
==========================================
- Coverage   79.94%   79.89%   -0.05%     
==========================================
  Files        1519     1520       +1     
  Lines      205869   206697     +828     
  Branches     2898     2906       +8     
==========================================
+ Hits       164572   165139     +567     
- Misses      40749    41010     +261     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 7bc6214 into pola-rs:main Sep 24, 2024
25 of 26 checks passed
@kszlim
Copy link
Contributor

kszlim commented Sep 24, 2024

Thanks @coastalwhite ! I've tested this and it fixes my issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants