Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure same fmt in Series/AnyValue to string cast #18982

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: Ensure same fmt in Series/AnyValue to string cast #18982

merged 1 commit into from
Sep 27, 2024

Conversation

ritchie46
Copy link
Member

fixes #18981

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (3904774) to head (aa2d9a5).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/datatypes/any_value.rs 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18982      +/-   ##
==========================================
- Coverage   79.86%   79.85%   -0.02%     
==========================================
  Files        1523     1523              
  Lines      207504   207510       +6     
  Branches     2904     2904              
==========================================
- Hits       165720   165703      -17     
- Misses      41237    41260      +23     
  Partials      547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit fa7ec47 into main Sep 27, 2024
26 checks passed
@ritchie46 ritchie46 deleted the cast branch September 27, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float literal formatting outputs different things dependent on where it is used
1 participant