-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(python): Annotate Config kwarg options #18988
docs(python): Annotate Config kwarg options #18988
Conversation
Regarding the mypy error,
Is the usual approach just |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18988 +/- ##
==========================================
- Coverage 79.88% 79.87% -0.02%
==========================================
Files 1524 1524
Lines 207634 207833 +199
Branches 2904 2908 +4
==========================================
+ Hits 165873 166005 +132
- Misses 41214 41279 +65
- Partials 547 549 +2 ☔ View full report in Codecov by Sentry. |
It's in tests; just type-ignore it and I'll approve/merge ;) |
Thanks! I also asked elsewhere and got the same recommendation, apparently the standard way of doing "something that asserts mypy should error" is just using |
Nice one; thanks for the PR 👍 |
Adds a TypedDict listing all valid options you can pass directly to Config()
Closes #18987