Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Batch utf8-validation in csv 18% / 25% on 1.9.0 #19124

Merged
merged 2 commits into from
Oct 7, 2024
Merged

perf: Batch utf8-validation in csv 18% / 25% on 1.9.0 #19124

merged 2 commits into from
Oct 7, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Oct 7, 2024
@ritchie46 ritchie46 changed the title perf: Batch utf8-validation in csv perf: Batch utf8-validation in csv 18% / 25% on 1.9.0 Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (addaf83) to head (898373b).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/csv/read/buffer.rs 75.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19124      +/-   ##
==========================================
- Coverage   79.81%   79.78%   -0.03%     
==========================================
  Files        1531     1531              
  Lines      208596   208611      +15     
  Branches     2913     2913              
==========================================
- Hits       166482   166440      -42     
- Misses      41563    41620      +57     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1e28cc7 into main Oct 7, 2024
25 checks passed
@ritchie46 ritchie46 deleted the csv branch October 7, 2024 15:42
@c-peters c-peters added the accepted Ready for implementation label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants