Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix floordiv / modulo with scalar 0 on LHS #19143

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #19142

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (018dfd1) to head (f7c653e).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-compute/src/arithmetic/unsigned.rs 0.00% 6 Missing ⚠️
crates/polars-compute/src/arithmetic/signed.rs 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19143      +/-   ##
==========================================
- Coverage   79.81%   79.77%   -0.04%     
==========================================
  Files        1531     1531              
  Lines      208576   208436     -140     
  Branches     2913     2913              
==========================================
- Hits       166466   166287     -179     
- Misses      41559    41598      +39     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 815e31f into pola-rs:main Oct 8, 2024
26 checks passed
@nameexhaustion nameexhaustion deleted the floordiv-scalar-0-lhs branch October 28, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect floordivide / modulo for literal broadcast 0 // <column>
2 participants