Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect (eq|ne)_missing on List/Array types #19155

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Oct 9, 2024

Regression causing eq/ne_missing to incorrectly give NULL when comparing NULLs instead of True/False

Fixes #19153

Adds

  • test_eq_lists_arrays for == / !=
  • test_eq_missing_lists_arrays_19153 for eq_missing / ne_missing

Tests are parametrized to test both lists and arrays

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 9, 2024
@nameexhaustion
Copy link
Collaborator Author

cc @coastalwhite

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (ee9bafb) to head (b5ef773).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19155      +/-   ##
==========================================
+ Coverage   79.78%   79.80%   +0.02%     
==========================================
  Files        1531     1531              
  Lines      208449   208461      +12     
  Branches     2913     2913              
==========================================
+ Hits       166317   166370      +53     
+ Misses      41581    41540      -41     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite
Copy link
Collaborator

I agree with the bug fix but the test adjustments I am not sure about.

Copy link
Collaborator

@coastalwhite coastalwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritchie46 ritchie46 merged commit 688e9b4 into pola-rs:main Oct 9, 2024
25 checks passed
@adamreeve
Copy link
Contributor

Thanks for the quick fix!

@nameexhaustion nameexhaustion deleted the list-eq-missing branch October 28, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in ne_missing and eq_missing behaviour with List columns
5 participants