-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix incorrect (eq|ne)_missing
on List/Array types
#19155
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19155 +/- ##
==========================================
+ Coverage 79.78% 79.80% +0.02%
==========================================
Files 1531 1531
Lines 208449 208461 +12
Branches 2913 2913
==========================================
+ Hits 166317 166370 +53
+ Misses 41581 41540 -41
Partials 551 551 ☔ View full report in Codecov by Sentry. |
I agree with the bug fix but the test adjustments I am not sure about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the quick fix! |
Regression causing
eq/ne_missing
to incorrectly give NULL when comparing NULLs instead of True/FalseFixes #19153
Adds
test_eq_lists_arrays
for==
/!=
test_eq_missing_lists_arrays_19153
foreq_missing
/ne_missing
Tests are parametrized to test both lists and arrays