Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Branchless Parquet Prefiltering #19190

Merged
merged 35 commits into from
Nov 1, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Oct 11, 2024

Change the Parquet decoders to use branchless filtering for the prefiltered methods.

This rewrites most of the decoders.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Oct 11, 2024
@coastalwhite coastalwhite force-pushed the perf/branchless-pq-prefiltering branch 3 times, most recently from 290d953 to 36b8d51 Compare October 24, 2024 09:32
@coastalwhite coastalwhite marked this pull request as ready for review October 24, 2024 11:41
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 79.79107% with 561 lines in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (69c9c3a) to head (e395c93).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...et/src/arrow/read/deserialize/fixed_size_binary.rs 69.86% 91 Missing ⚠️
...lars-parquet/src/arrow/read/deserialize/boolean.rs 62.50% 87 Missing ⚠️
...quet/src/arrow/read/deserialize/primitive/plain.rs 76.47% 80 Missing ⚠️
...lars-parquet/src/arrow/read/deserialize/binview.rs 79.58% 78 Missing ⚠️
...t/src/arrow/read/deserialize/utils/dict_encoded.rs 90.35% 68 Missing ⚠️
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 68.15% 50 Missing ⚠️
crates/polars-arrow/src/types/aligned_bytes.rs 0.00% 28 Missing ⚠️
...parquet/src/arrow/read/deserialize/nested_utils.rs 90.30% 22 Missing ⚠️
crates/polars-arrow/src/bitmap/bitmask.rs 46.15% 14 Missing ⚠️
...et/src/arrow/read/deserialize/primitive/integer.rs 82.89% 13 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19190      +/-   ##
==========================================
+ Coverage   80.03%   80.16%   +0.12%     
==========================================
  Files        1532     1531       -1     
  Lines      210749   210193     -556     
  Branches     2442     2442              
==========================================
- Hits       168676   168494     -182     
+ Misses      41518    41144     -374     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite force-pushed the perf/branchless-pq-prefiltering branch from e395c93 to b9db606 Compare October 31, 2024 14:16
@coastalwhite coastalwhite added the needs-bench Needs a benchmark run label Oct 31, 2024
@coastalwhite
Copy link
Collaborator Author

ping @ritchie46.

@coastalwhite coastalwhite force-pushed the perf/branchless-pq-prefiltering branch from b9db606 to 9ea1775 Compare November 1, 2024 10:59
@ritchie46 ritchie46 merged commit 3fe10a3 into pola-rs:main Nov 1, 2024
22 of 23 checks passed
@coastalwhite coastalwhite deleted the perf/branchless-pq-prefiltering branch November 1, 2024 11:52
@c-peters c-peters added the accepted Ready for implementation label Nov 4, 2024
coastalwhite added a commit to coastalwhite/polars that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation needs-bench Needs a benchmark run performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants