-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Branchless Parquet Prefiltering #19190
Merged
ritchie46
merged 35 commits into
pola-rs:main
from
coastalwhite:perf/branchless-pq-prefiltering
Nov 1, 2024
Merged
perf: Branchless Parquet Prefiltering #19190
ritchie46
merged 35 commits into
pola-rs:main
from
coastalwhite:perf/branchless-pq-prefiltering
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
Performance issues or improvements
python
Related to Python Polars
rust
Related to Rust Polars
labels
Oct 11, 2024
orlp
requested changes
Oct 11, 2024
crates/polars-parquet/src/arrow/read/deserialize/primitive/integer.rs
Outdated
Show resolved
Hide resolved
crates/polars-parquet/src/arrow/read/deserialize/primitive/integer.rs
Outdated
Show resolved
Hide resolved
crates/polars-parquet/src/arrow/read/deserialize/utils/dict_encoded.rs
Outdated
Show resolved
Hide resolved
coastalwhite
force-pushed
the
perf/branchless-pq-prefiltering
branch
3 times, most recently
from
October 24, 2024 09:32
290d953
to
36b8d51
Compare
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
October 24, 2024 11:41
coastalwhite
force-pushed
the
perf/branchless-pq-prefiltering
branch
from
October 31, 2024 14:16
e395c93
to
b9db606
Compare
ping @ritchie46. |
coastalwhite
force-pushed
the
perf/branchless-pq-prefiltering
branch
from
November 1, 2024 10:59
b9db606
to
9ea1775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Ready for implementation
needs-bench
Needs a benchmark run
performance
Performance issues or improvements
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Parquet decoders to use branchless filtering for the
prefiltered
methods.This rewrites most of the decoders.