fix: Parquet predicate pushdown for lit(_) !=
#19246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
coastalwhite
commented
Oct 15, 2024
| @@ -354,7 +354,7 @@ mod stats { | |||
| use ChunkCompareIneq as C; | |||
| match op { | |||
| Operator::Eq => apply_operator_stats_eq(min_max, literal), | |||
| Operator::NotEq => apply_operator_stats_eq(min_max, literal), | |||
| Operator::NotEq => apply_operator_stats_neq(min_max, literal), | |||
There was a problem hiding this comment.
This is the actual fix. The rest are all drive-by's.
coastalwhite
changed the title
lit(_) !=.lit(_) !=
github-actions
bot
added
fix
coastalwhite
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19246 +/- ##
==========================================
+ Coverage 79.68% 80.02% +0.34%
==========================================
Files 1532 1528 -4
Lines 209211 209570 +359
Branches 2416 2415 -1
==========================================
+ Hits 166710 167716 +1006
+ Misses 41953 41306 -647
Partials 548 548 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19238.