-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust): Purge arrow-rs support #19312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19312 +/- ##
==========================================
+ Coverage 80.02% 80.22% +0.20%
==========================================
Files 1528 1523 -5
Lines 209871 209495 -376
Branches 2419 2434 +15
==========================================
+ Hits 167954 168073 +119
+ Misses 41366 40867 -499
- Partials 551 555 +4 ☔ View full report in Codecov by Sentry. |
A rebase away. |
:( |
Isn't this a breaking change? |
For rust it is. And it will be in a major version bump. @deanm0000 did you use this? As it is arrow, you can still use ffi for this. |
I was using to interop with geoarrow, or try to anyway |
This reverts commit f88bd6a.
Hi, @ritchie46
Is there an ffi example? Thanks! |
This was a legacy holdover from before polars-arrow was vendored, we never used this.