Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve error message for Zero-Field Structs with Parquet #19370

Merged

Conversation

coastalwhite
Copy link
Collaborator

Related to #19352.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (8a76dad) to head (0358685).
Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-parquet/src/arrow/write/schema.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19370      +/-   ##
==========================================
- Coverage   80.24%   80.21%   -0.03%     
==========================================
  Files        1523     1523              
  Lines      209545   209859     +314     
  Branches     2434     2434              
==========================================
+ Hits       168148   168345     +197     
- Misses      40842    40959     +117     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit aaf4578 into pola-rs:main Oct 22, 2024
20 of 21 checks passed
@coastalwhite coastalwhite deleted the refactor/better-parquet-zfs-error branch October 22, 2024 13:29
@c-peters c-peters added the accepted Ready for implementation label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants