Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Capture groups should be ignored in replace when literal=True #19413

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

corwinjoy
Copy link
Contributor

Followup to #19366

in replace, when literal=True, then capture groups should be ignored.

I missed that in the original bug report, #18238, the capture group issue affects replace in addition to replace_all.
This fixed the capture group logic for replace.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (69c9c3a) to head (43f5d92).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...rates/polars-plan/src/dsl/function_expr/strings.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19413      +/-   ##
==========================================
- Coverage   80.03%   80.02%   -0.02%     
==========================================
  Files        1532     1532              
  Lines      210749   210750       +1     
  Branches     2442     2442              
==========================================
- Hits       168676   168652      -24     
- Misses      41518    41543      +25     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a38dea6 into pola-rs:main Oct 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants