Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates error message in csv parser to recommend schema_overrides instead of deprecated dtypes argument #19416

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dvillaveces
Copy link
Contributor

Very small PR. I found it a little annoying that the error message recommends using an argument that has been deprecated and gives a warning, instead of recommending the updated argument. So I decided to try and fix it 😄

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.04%. Comparing base (69c9c3a) to head (cd08af9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19416      +/-   ##
==========================================
+ Coverage   80.03%   80.04%   +0.01%     
==========================================
  Files        1532     1532              
  Lines      210749   210749              
  Branches     2442     2442              
==========================================
+ Hits       168676   168699      +23     
+ Misses      41518    41495      -23     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good decision. Thanks!

@ritchie46 ritchie46 merged commit f01fb7b into pola-rs:main Oct 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants