Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Add tests for data mismatch on read_json #19425

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Add some explicit tests for read_json - the underlying code was already fixed by #19347 as it is shared with str.json_decode

@nameexhaustion nameexhaustion changed the title tests(python): Add tests for data mismatch on read_json test(python): Add tests for data mismatch on read_json Oct 24, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars and removed title needs formatting labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (69c9c3a) to head (48d17d0).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19425   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files        1532     1532           
  Lines      210749   210749           
  Branches     2442     2442           
=======================================
+ Hits       168676   168677    +1     
+ Misses      41518    41517    -1     
  Partials      555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b9084b7 into pola-rs:main Oct 24, 2024
13 of 14 checks passed
@nameexhaustion nameexhaustion deleted the json-tests branch October 28, 2024 04:53
@c-peters c-peters added the accepted Ready for implementation label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants