Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix row_index of batched reader #19465

Merged
merged 3 commits into from
Oct 26, 2024
Merged

fix: Fix row_index of batched reader #19465

merged 3 commits into from
Oct 26, 2024

Conversation

ritchie46
Copy link
Member

fixes #19460

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.92%. Comparing base (ce001f1) to head (6621732).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/utils/other.rs 87.87% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19465      +/-   ##
==========================================
- Coverage   79.95%   79.92%   -0.04%     
==========================================
  Files        1534     1534              
  Lines      211053   211123      +70     
  Branches     2444     2444              
==========================================
- Hits       168751   168743       -8     
- Misses      41747    41825      +78     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 7e9e784 into main Oct 26, 2024
20 checks passed
@ritchie46 ritchie46 deleted the idx branch October 26, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join results in too many rows when joining a large dataset with streaming=True
1 participant