Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure sorted flag is unset after Int->String cast #19470

Merged
merged 2 commits into from
Oct 27, 2024
Merged

fix: Ensure sorted flag is unset after Int->String cast #19470

merged 2 commits into from
Oct 27, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 26, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review October 26, 2024 22:30
@codecov Codecov
Copy link

codecov bot commented Oct 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (e7a84bc) to head (fbcd754).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #19470   +/-   ##
=======================================
  Coverage   79.94%   79.95%           
=======================================
  Files        1534     1534           
  Lines      211183   211182    -1     
  Branches     2444     2444           
=======================================
+ Hits       168831   168845   +14     
+ Misses      41797    41782   -15     
  Partials      555      555

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b222796 into pola-rs:main Oct 27, 2024
25 checks passed
@nameexhaustion nameexhaustion deleted the cast-sorted branch October 28, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect sorted flag propagation when casting from numeric to string type
2 participants
@nameexhaustion @ritchie46