feat: Implement nested Parquet writing for High-Precision Decimals #19476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements writing the writing of arbitrary nested `FixedSizeBinary`, which in particular allows for the writing of nested high-precision decimals. This removes the silent data-loss that was happening before. Fixes pola-rs#19448.
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19476 +/- ##
==========================================
+ Coverage 79.90% 80.00% +0.10%
==========================================
Files 1534 1536 +2
Lines 211161 211261 +100
Branches 2444 2445 +1
==========================================
+ Hits 168732 169026 +294
+ Misses 41874 41680 -194
Partials 555 555 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements writing the writing of arbitrary nested
FixedSizeBinary, which in particular allows for the writing of nested high-precision decimals. This removes the silent data-loss that was happening before.Fixes #19448.