New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make Duration parsing fallible and not panic #19490

Merged

ritchie46 merged 3 commits into pola-rs:main from coastalwhite:fix/duration-parse-panic

Oct 28, 2024

Collaborator

coastalwhite commented Oct 28, 2024

Fixes #19478.


          fix: Make Duration parsing fallible and not panic

73222a6

coastalwhite requested review from ritchie46, c-peters, alexander-beedie, MarcoGorelli, reswqa and orlp as code owners

October 28, 2024 08:07

github-actions bot added fix python rust labels

coastalwhite added 2 commits

October 28, 2024 09:25


          fix tests

713bc77


          fix broken import

b99bdc9

MarcoGorelli approved these changes

View reviewed changes

Collaborator

MarcoGorelli left a comment

nice one @coastalwhite

ritchie46 merged commit 75aa4a3 into pola-rs:main

23 of 25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MarcoGorelli MarcoGorelli approved these changes

ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

c-peters Awaiting requested review from c-peters c-peters is a code owner

alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

reswqa Awaiting requested review from reswqa reswqa is a code owner

orlp Awaiting requested review from orlp orlp is a code owner

Labels

fix python rust