Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rust): Fix some feature flag issues #19512

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

stinodego
Copy link
Member

Closes #19485

@github-actions github-actions bot added build Changes that affect the build system or external dependencies rust Related to Rust Polars labels Oct 29, 2024
@orlp
Copy link
Collaborator

orlp commented Oct 29, 2024

I'm not sure that actually fixes the linked issue long-term. We should update the polars-stream toml to properly respect and propagate feature flags instead of unconditionally enabling them, especially python.

@stinodego
Copy link
Member Author

I'm not sure that actually fixes the linked issue long-term. We should update the polars-stream toml to properly respect and propagate feature flags instead of unconditionally enabling them, especially python.

You're right. I tried going down the rabbit hole in #19511 but well, it's quite a rabbit hole...

This should fix the direct problem people are running into (polars-stream being compiled without explicitly requesting it) - then we can do some feature flag improvements at a later point.

@stinodego stinodego marked this pull request as ready for review October 29, 2024 11:06
@ritchie46 ritchie46 merged commit 1c1574a into main Oct 29, 2024
20 of 21 checks passed
@ritchie46 ritchie46 deleted the fix-feature-flag-python branch October 29, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polars 0.44.0 includes pyo3 and other extra dependencies by default
3 participants