Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Fix test_rolling_by_integer not using parameterized dtype #19555

Merged

Conversation

HansBambel
Copy link
Contributor

This PR is for fixing a small issue in the test test_rolling_by_integer.

This was noticed here: #19071 (comment)

Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @HansBambel !

@MarcoGorelli
Copy link
Collaborator

merging then as ci failure is unrelated

@MarcoGorelli MarcoGorelli merged commit ebeeea7 into pola-rs:main Oct 31, 2024
12 of 13 checks passed
@HansBambel HansBambel deleted the fix-test-test_rolling_by_integer branch October 31, 2024 21:13
coastalwhite pushed a commit to coastalwhite/polars that referenced this pull request Nov 5, 2024
…type (pola-rs#19555)

Co-authored-by: HansBambel <hans-bambel@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants