Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix mask and validity confusion in Parquet String decoding #19614

Merged
merged 2 commits into from
Nov 3, 2024
Merged

fix: Fix mask and validity confusion in Parquet String decoding #19614

merged 2 commits into from
Nov 3, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 3, 2024
@coastalwhite coastalwhite changed the title fix: Fix typo in Parquet String decoding fix: Fix mask and validity confusion in Parquet String decoding Nov 3, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.97%. Comparing base (7d93ec4) to head (a43072b).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...lars-parquet/src/arrow/read/deserialize/binview.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #19614      +/-   ##
==========================================
+ Coverage   79.84%   79.97%   +0.12%     
==========================================
  Files        1536     1536              
  Lines      211375   211374       -1     
  Branches     2445     2445              
==========================================
+ Hits       168781   169038     +257     
+ Misses      42039    41781     -258     
  Partials      555      555

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit 0b0a914 into pola-rs:main Nov 3, 2024
26 checks passed
@coastalwhite coastalwhite deleted the fix/parquet-string-decoding-typo branch November 3, 2024 17:26
@c-peters c-peters added the accepted Ready for implementation label Nov 4, 2024
coastalwhite added a commit to coastalwhite/polars that referenced this pull request Nov 5, 2024
@coastalwhite
fix: Fix mask and validity confusion in Parquet String decoding (pola…
7f16305 
…-rs#19614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@coastalwhite coastalwhite

Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coastalwhite @c-peters