fix: Fix incorrect lazy schema for explode() in agg()
#19623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Nov 4, 2024
| @@ -170,7 +170,7 @@ impl ApplyExpr { | |||
| // })? | |||
| let out: ListChunked = POOL.install(|| iter.collect::<PolarsResult<_>>())?; | |||
|
|
|||
| debug_assert_eq!(out.dtype(), &DataType::List(Box::new(dtype))); | |||
| debug_assert_eq!(&dtype, out.dtype()); | |||
There was a problem hiding this comment.
I think the output field of the expression should created in an aggregation-context-aware manner, so I've updated this assertion.
nameexhaustion
commented
Nov 4, 2024
| @@ -239,7 +239,7 @@ fn create_physical_expr_inner( | |||
| // TODO! Order by | |||
| let group_by = create_physical_expressions_from_nodes( | |||
| partition_by, | |||
| Context::Default, | |||
| Context::Aggregation, | |||
There was a problem hiding this comment.
This is under AExpr::Window
nameexhaustion
commented
Nov 4, 2024
| @@ -72,7 +72,6 @@ impl AExpr { | |||
| }, | |||
| Explode(expr) => { | |||
| let field = arena.get(*expr).to_field_impl(schema, arena, nested)?; | |||
| *nested = nested.saturating_sub(1); | |||
There was a problem hiding this comment.
Fix for the linked issue explode()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19623 +/- ##
==========================================
- Coverage 79.92% 79.92% -0.01%
==========================================
Files 1536 1536
Lines 211686 211695 +9
Branches 2445 2445
==========================================
+ Hits 169192 169197 +5
- Misses 41939 41943 +4
Partials 555 555 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
reviewed
Nov 4, 2024
| expr_arena | ||
| .get(expression) | ||
| .to_field(schema, Context::Default, expr_arena)?; | ||
| if let Context::Aggregation = ctxt { |
There was a problem hiding this comment.
I think we should just pass the context to line 497 instead of updating the dtype here.
ritchie46
reviewed
Nov 4, 2024
| expr_arena | ||
| .get(expression) | ||
| .to_field(schema, Context::Default, expr_arena)?; | ||
| if let Context::Aggregation = ctxt { |
nameexhaustion
force-pushed
the
agg-field-dtype
branch
from
99046fb
to
6c883d0
Compare
nameexhaustion
added
do not merge
|
I think I have this figured out, will close in favor of #19629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19562nvm, I have a better fix in newer PR. This one is more of a hack