fix(python): Ensure NoDataError raised consistently between engines for Excel reads
#19712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
max-muoto
changed the title
github-actions
bot
added
title needs formatting
fix
max-muoto
commented
Nov 10, 2024
| @@ -997,15 +997,15 @@ def _read_spreadsheet_calamine( | |||
| ): | |||
| df.columns = [f"column_{i}" for i in range(1, len(df.columns) + 1)] | |||
|
|
|||
| df = _drop_null_data( | |||
There was a problem hiding this comment.
Drop null data first, which will potentially raise a no data error.
max-muoto
changed the title
|
Looks good to me; nice extension on the existing test 👌 |
alexander-beedie
approved these changes
Nov 10, 2024
alexander-beedie
changed the title
NoDataError raised consistently between engines for Excel reads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #19711 ensuring that a no data error is raised for Calamine reads even when schema overrides are provided.