Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Use cls for to_python #19726

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(python): Use cls for to_python #19726

merged 1 commit into from
Nov 11, 2024

Conversation

max-muoto
Copy link
Contributor

cls should be taken for this class method.

@max-muoto max-muoto changed the title fix(Python): cls -> Self for to_python fix(python): self -> cls for to_python Nov 11, 2024
@max-muoto max-muoto changed the title fix(python): self -> cls for to_python fix(python): Use cls for to_python Nov 11, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Nov 11, 2024
alexander-beedie
alexander-beedie approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexander-beedie alexander-beedie merged commit 4fb7cd1 into pola-rs:main Nov 11, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-beedie alexander-beedie alexander-beedie approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-muoto @alexander-beedie