-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate polars-expr AggregationContext to use Column
#19736
Merged
ritchie46
merged 10 commits into
pola-rs:main
from
coastalwhite:refactor/aggregation-context-column
Nov 14, 2024
Merged
refactor: Migrate polars-expr AggregationContext to use Column
#19736
ritchie46
merged 10 commits into
pola-rs:main
from
coastalwhite:refactor/aggregation-context-column
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
November 12, 2024 08:50
github-actions
bot
added
internal
An internal refactor or improvement
python
Related to Python Polars
rust
Related to Rust Polars
labels
Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19736 +/- ##
==========================================
- Coverage 79.73% 79.72% -0.01%
==========================================
Files 1542 1544 +2
Lines 212223 212846 +623
Branches 2449 2441 -8
==========================================
+ Hits 169216 169693 +477
- Misses 42453 42604 +151
+ Partials 554 549 -5 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.