fix: Fix incorrect lazy schema for explode on array columns #19776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Nov 14, 2024
nameexhaustion
commented
Nov 14, 2024
| @@ -132,7 +132,7 @@ impl From<ArrayFunction> for SpecialEq<Arc<dyn ColumnsUdf>> { | |||
| #[cfg(feature = "array_count")] | |||
| CountMatches => map_as_slice!(count_matches), | |||
| Shift => map_as_slice!(shift), | |||
| Explode => unreachable!(), | |||
| Explode => map_as_slice!(explode), | |||
There was a problem hiding this comment.
I've also removed some code further down that re-wrote ArrayFunction::Explode to AExpr::Explode - it was being done in the optimizer stage which isn't guaranteed to be hit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19776 +/- ##
=======================================
Coverage 79.55% 79.55%
=======================================
Files 1544 1544
Lines 213240 213241 +1
Branches 2441 2441
=======================================
+ Hits 169645 169654 +9
+ Misses 43046 43038 -8
Partials 549 549 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19763
Our lazy schema for an exploded array column was not correct. I think this was only starting causing issues with joins after #19625 because we never used this schema information before then