fix: Altair tooltip was being incorrectly applied to plots which did not accept it #19789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
MarcoGorelli
force-pushed
the
tooltip
branch
from
b136f63
to
06cdb97
Compare
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19789 +/- ##
===========================================
+ Coverage 59.87% 79.56% +19.69%
===========================================
Files 1545 1545
Lines 213433 213442 +9
Branches 2442 2444 +2
===========================================
+ Hits 127791 169827 +42036
+ Misses 85092 43065 -42027
Partials 550 550 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19787
An alternative would be to just never pass
tooltipin the generic case, but I thinkinspect.signatureis safe enough