feat(python): Support DataFrame init from raw SQLAlchemy rows #19820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19816.
With a trivial extension to the existing Sequence checks we can support direct DataFrame/Series init from a list of SQLAlchemy
Row
objects, as they intentionally mimicnamedtuple
in various ways1.This allows for a very small (low single-digit percentage) speedup ingesting SQLAlchemy results via
read_database
, so I've taken advantage of that (against a 50000x10 test dataset I was seeing ~1-2% gains - but it's not 0%, so why not...😅)Footnotes
sqlalchemy.engine.Row ↩