fix(python): Fix read_database(…,iter_batches=True) type annotations
#19832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in a if TYPE_CHECKING block no runtime behavior can exist, such as try-excepts. They were replaced by a single import
iliya-malecki
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19832 +/- ##
=======================================
Coverage 79.33% 79.33%
=======================================
Files 1548 1548
Lines 214247 214247
Branches 2460 2460
=======================================
+ Hits 169971 169974 +3
+ Misses 43718 43715 -3
Partials 558 558 ☔ View full report in Codecov by Sentry. |
alexander-beedie
approved these changes
Nov 17, 2024
alexander-beedie
changed the title
read_database(..., iter_batches=True) type annotations
alexander-beedie
changed the title
read_database(..., iter_batches=True) type annotationsread_database(…, iter_batches=True) type annotations
alexander-beedie
changed the title
read_database(…, iter_batches=True) type annotationsread_database(…,iter_batches=True) type annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19800.
Fixed the typing and while i was at it i fixed the typing a little deeper, including returning Iterator from inner functions and importing Selectable correctly in an if TYPE_CHECKING block.