fix: Improve binning in Series.hist
with bin_count
when all values are the same
#20034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20030.
I added a skip condition to the
test_hist_rand
to address "flaky failure" in the same-value case, since including it would increase the complexity of the test. It's easier to just include the separate test.New behavior uses a unit interval, as it does in the single-value case:
I think this could use a further improvement and should probably only have a single bin, but that can be a different discussion.