Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve GroupsProxy/GroupsPosition to be sliceable and cheaply cloneable #20673

Merged
merged 7 commits into from
Jan 12, 2025

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jan 12, 2025

Preparation for #20669

@ritchie46 ritchie46 changed the title feat: Improve GroupsProxy/GroupsPosition to be sliceable and cheaply cloneable. feat: Improve GroupsProxy/GroupsPosition to be sliceable and cheaply cloneable Jan 12, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jan 12, 2025
Copy link
Contributor

The uncompressed lib size after this PR is 38.9850 MB.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 80.16949% with 117 lines in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (87baf86) to head (9a33de7).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/group_by/position.rs 89.60% 13 Missing ⚠️
crates/polars-expr/src/expressions/slice.rs 62.50% 9 Missing ⚠️
...rs-core/src/frame/group_by/aggregations/boolean.rs 27.27% 8 Missing ⚠️
crates/polars-core/src/series/series_trait.rs 20.00% 8 Missing ⚠️
crates/polars-expr/src/expressions/mod.rs 79.41% 7 Missing ⚠️
...polars-core/src/frame/group_by/aggregations/mod.rs 84.61% 6 Missing ⚠️
...s/polars-core/src/series/implementations/binary.rs 0.00% 5 Missing ⚠️
...s-core/src/frame/group_by/aggregations/agg_list.rs 71.42% 4 Missing ⚠️
.../polars-core/src/series/implementations/boolean.rs 63.63% 4 Missing ⚠️
crates/polars-expr/src/expressions/window.rs 78.94% 4 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20673      +/-   ##
==========================================
+ Coverage   78.85%   78.99%   +0.14%     
==========================================
  Files        1558     1559       +1     
  Lines      221055   221204     +149     
  Branches     2527     2527              
==========================================
+ Hits       174318   174751     +433     
+ Misses      46159    45876     -283     
+ Partials      578      577       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 7bca692 into main Jan 12, 2025
23 of 24 checks passed
@ritchie46 ritchie46 deleted the groups branch January 12, 2025 15:40
@c-peters c-peters added the accepted Ready for implementation label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants