Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect height from slicing after projecting only the file path column #20817

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #20788

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (b4b8f81) to head (fb25d27).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...polars-mem-engine/src/executors/multi_file_scan.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20817   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files        1568     1568           
  Lines      222969   222985   +16     
  Branches     2544     2544           
=======================================
+ Hits       177696   177717   +21     
+ Misses      44689    44684    -5     
  Partials      584      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion changed the title fix: Incorrect height when projecting only the file path column fix: Incorrect height from slicing after projecting only the file path column Jan 21, 2025
@ritchie46 ritchie46 merged commit 4c7c8c4 into pola-rs:main Jan 21, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants