Improving Python DataType support for Struct and repr #3471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #3413, I noticed that the Python representation of DataTypes has some issues. This PR fixes a few of them:
DataType::Struct
, since previously it had an incomplete representationdtype_string_repr
was not implemented yet, so it always failed to importThe
__repr__
behavior is a bit odd, but much closer in this PR to the Rust API. This is because the class is being used as a singleton without being constructed --type(dtype) == type
. So for native typesrepr(dtype)
is actuallytype(dtype).__repr__(dtype)
which gives strings like"<class 'polars.datatypes.Utf8'>"
. I left theDataType.string_repr
method, but made it more clear that as a classmethod this usescls
notself
. I think this could be improved by having an instantiated singleton that the class provides on the new constructor. This can be a follow up.